jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/710664 ) Change subject: [bugfix] Relax assertion in WikidataBot.treat_page ...................................................................... [bugfix] Relax assertion in WikidataBot.treat_page This assertion was wrong. page may be None, it is even assigned to it above. Change-Id: I05f4fd713625ded61bee7efe5e0c30d45b582b2d --- M pywikibot/bot.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/bot.py b/pywikibot/bot.py index bfff4b2..a623dff 100644 --- a/pywikibot/bot.py +++ b/pywikibot/bot.py @@ -2303,7 +2303,7 @@ 'must be an item.'.format(page)) return - assert page is not None + assert not (page is None and item is None) if not item and self.create_missing_item: item = self.create_item_for_page(page, asynchronous=False) -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/710664 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I05f4fd713625ded61bee7efe5e0c30d45b582b2d Gerrit-Change-Number: 710664 Gerrit-PatchSet: 1 Gerrit-Owner: Matěj Suchánek <matejsuchanek97(a)gmail.com> Gerrit-Reviewer: Damian <atagar1(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged