Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1032782?usp=email ) Change subject: [tests] Use pep8-naming 0.13.3 with Python 3.7 ...................................................................... [tests] Use pep8-naming 0.13.3 with Python 3.7 Use pep8-naming 0.13.3 with Python 3.7 due to missing walross operator support. Also remove "ignore-names" because the lowest version is 0.13.3 Bug: T365247 Change-Id: I8cb7d88718038dbba9a28cb16ed8c31cb461e08a --- M setup.py M tox.ini 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/setup.py b/setup.py index cb14e17..6190686 100755 --- a/setup.py +++ b/setup.py @@ -64,7 +64,8 @@ 'flake8-string-format', 'flake8-tuple>=0.4.1', 'flake8-no-u-prefixed-strings>=0.2', - 'pep8-naming>=0.13.3', + 'pep8-naming==0.13.3; python_version < "3.8"', + 'pep8-naming>=0.14.0; python_version >= "3.8"', ], 'hacking': [ 'hacking', diff --git a/tox.ini b/tox.ini index 8ab5836..f7cb582 100644 --- a/tox.ini +++ b/tox.ini @@ -235,8 +235,6 @@ # pep8-naming classmethod-decorators = classmethod,classproperty -# required with pep8-naming < 0.13 -ignore-names = setUp,tearDown,setUpClass,tearDownClass,setUpModule,tearDownModule,asyncSetUp,asyncTearDown,setUpTestData,failureException,longMessage,maxDiff [isort] py_version = 37 -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1032782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I8cb7d88718038dbba9a28cb16ed8c31cb461e08a Gerrit-Change-Number: 1032782 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged