Removing upload interface code from MobileFrontend - Mobile-l

Jeff Hobson

11 May 11 May

5:21 p.m.

New subject: Removing upload interface code from MobileFrontend

Is there any precedent for an "un-maintained (legacy) extension"? If so, we could move it to an extension so it's still enableable by 3rd parties but strongly express that it will not be maintained and any bugs would not be triaged (with an explanation that the editing team is working on a newer version, of course). Thanks, Jeff Hobson On Mon, May 11, 2015 at 1:12 PM, Jon Robson <jrobson(a)wikimedia.org> wrote:

...

A while back we disabled the mobile uploads interface in mobile. It's been sitting in our codebase dormant so people can enable it via user js if necessary but it's broken a few times and doesn't seem to be getting the attention it needs. Given there is now an editing team and from what I understand UploadWizard is being refactored into oojs ui (which will lead to it being less bulky and more mobile friendly) I'd like to suggest we abandon the code in MobileFrontend and help support that effort. Note this effort is likely to take a long long time, since that extension suffers from much technical debt and makes use of jquery ui, which is not available on mobile, so to set expectations we're not going to be in a state where we can enable this on mobile (if we wanted to which again is highly questionable) any time soon (think in units of a year rather than weeks/months). The downside of this is any 3rd parties who are using this uploads code (it's turned on by default) will lose this feature and there is no available alternative. I've written a patch to remove it [1] but I just wanted to post this here to give people the chance to voice any concerns/disagree with this approach. Note: We can always restore the code later on if necessary. I argue this will be easier than fixing/maintaining the existing code. Someone could also put it into a separate extension if they wanted to use it. See also: https://phabricator.wikimedia.org/T97169 [1] https://gerrit.wikimedia.org/r/#/c/210084/ _______________________________________________ Mobile-l mailing list Mobile-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l

Reply

Joaquin Oltra Hernandez

12 May 12 May

9:22 a.m.

New subject: Removing upload interface code from MobileFrontend

I say kill it with fire. I like the feature but it doesn't seem like it is going to get any attention and it is effectively abandoned code. If we needed we can always bring it back without any issues. I agree with Kaldari, if we do it we should have a Special:Upload minerva page in following sprints. On Tue, May 12, 2015 at 1:27 AM, Ryan Kaldari <rkaldari(a)wikimedia.org> wrote:

...

I think killing our uploading interface is a probably a good idea (assuming maintaining it isn't going to be a priority any time soon). However, I think that if we kill it, we should at least clean up Special:Upload so that it works OK in Minerva (shouldn't take much work). This will give 3rd party users a minimal uploading interface if they want it and also better position us for Minerva on desktop. Once it is working adequately, we could just have a feature flag to add a link to it from the hamburger menu (similar to the prior link to Special:Uploads). On Mon, May 11, 2015 at 10:12 AM, Jon Robson <jrobson(a)wikimedia.org> wrote:

A while back we disabled the mobile uploads interface in mobile. It's been sitting in our codebase dormant so people can enable it via user js if necessary but it's broken a few times and doesn't seem to be getting the attention it needs. Given there is now an editing team and from what I understand UploadWizard is being refactored into oojs ui (which will lead to it being less bulky and more mobile friendly) I'd like to suggest we abandon the code in MobileFrontend and help support that effort. Note this effort is likely to take a long long time, since that extension suffers from much technical debt and makes use of jquery ui, which is not available on mobile, so to set expectations we're not going to be in a state where we can enable this on mobile (if we wanted to which again is highly questionable) any time soon (think in units of a year rather than weeks/months). The downside of this is any 3rd parties who are using this uploads code (it's turned on by default) will lose this feature and there is no available alternative. I've written a patch to remove it [1] but I just wanted to post this here to give people the chance to voice any concerns/disagree with this approach. Note: We can always restore the code later on if necessary. I argue this will be easier than fixing/maintaining the existing code. Someone could also put it into a separate extension if they wanted to use it. See also: https://phabricator.wikimedia.org/T97169 [1] https://gerrit.wikimedia.org/r/#/c/210084/ _______________________________________________ Mobile-l mailing list Mobile-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l

_______________________________________________ Mobile-l mailing list Mobile-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l

Reply

Jon Robson

11:26 a.m.

New subject: Removing upload interface code from MobileFrontend

Note: Special:Upload currently works on mobile (well any device that supports it). Not sure what work is seen as required there... On Tue, May 12, 2015 at 11:22 AM, Sam Smith <samsmith(a)wikimedia.org> wrote:

...

I agree that we should get Special:Upload working suitably well on mobile too. I'd consider that a blocker for removing the code. We have to act responsibly when removing code, regardless of how much we dislike it. –Sam On Tue, May 12, 2015 at 10:22 AM, Joaquin Oltra Hernandez < jhernandez(a)wikimedia.org> wrote:

I say kill it with fire. I like the feature but it doesn't seem like it is going to get any attention and it is effectively abandoned code. If we needed we can always bring it back without any issues. I agree with Kaldari, if we do it we should have a Special:Upload minerva page in following sprints. On Tue, May 12, 2015 at 1:27 AM, Ryan Kaldari <rkaldari(a)wikimedia.org> wrote:

I think killing our uploading interface is a probably a good idea (assuming maintaining it isn't going to be a priority any time soon). However, I think that if we kill it, we should at least clean up Special:Upload so that it works OK in Minerva (shouldn't take much work). This will give 3rd party users a minimal uploading interface if they want it and also better position us for Minerva on desktop. Once it is working adequately, we could just have a feature flag to add a link to it from the hamburger menu (similar to the prior link to Special:Uploads). On Mon, May 11, 2015 at 10:12 AM, Jon Robson <jrobson(a)wikimedia.org> wrote:

A while back we disabled the mobile uploads interface in mobile. It's been sitting in our codebase dormant so people can enable it via user js if necessary but it's broken a few times and doesn't seem to be getting the attention it needs. Given there is now an editing team and from what I understand UploadWizard is being refactored into oojs ui (which will lead to it being less bulky and more mobile friendly) I'd like to suggest we abandon the code in MobileFrontend and help support that effort. Note this effort is likely to take a long long time, since that extension suffers from much technical debt and makes use of jquery ui, which is not available on mobile, so to set expectations we're not going to be in a state where we can enable this on mobile (if we wanted to which again is highly questionable) any time soon (think in units of a year rather than weeks/months). The downside of this is any 3rd parties who are using this uploads code (it's turned on by default) will lose this feature and there is no available alternative. I've written a patch to remove it [1] but I just wanted to post this here to give people the chance to voice any concerns/disagree with this approach. Note: We can always restore the code later on if necessary. I argue this will be easier than fixing/maintaining the existing code. Someone could also put it into a separate extension if they wanted to use it. See also: https://phabricator.wikimedia.org/T97169 [1] https://gerrit.wikimedia.org/r/#/c/210084/ _______________________________________________ Mobile-l mailing list Mobile-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l

_______________________________________________ Mobile-l mailing list Mobile-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mobile-l

-- Jon Robson * http://jonrobson.me.uk * https://www.facebook.com/jonrobson * @rakugojon

Reply

Sam Smith

12:44 p.m.

New subject: Removing upload interface code from MobileFrontend

Neato! Could you create a task to get rid of the upload code if there isn't one already? The task you've linked from your patch [0] only covers not loading the styles [1]. –Sam [0] https://gerrit.wikimedia.org/r/#/c/210084/ [1] https://phabricator.wikimedia.org/T98402 On Tue, May 12, 2015 at 12:57 PM, Federico Leva (Nemo) <nemowiki(a)gmail.com> wrote:

...

Jon Robson, 12/05/2015 13:26:

Note: Special:Upload currently works on mobile (well any device that supports it). Not sure what work is seen as required there...

Then kill the custom interface, link Special:Upload from the menu as normal. Bugs can be filed iteratively. Nemo

Reply