MobileFrontend peeps:

Is it okay to remove the following line from SkinMobile.php, line 50?

wfRunHooks( 'GetMobileNotice', array( $this, &$notice ) );

Removal would reduce unnecessary double execution of the Wikipedia Zero banner rendering code in HTML contexts.

Note that SkinMobileWML.php, line 34, will still call GetMobileNotice, but I don't think we need the invocation from SkinMobile.php, line 50, unless some other component will be using it, such as CentralNotice. I get the impression that CentralNotice doesn't actually use GetMobileNotice, given the following code on line 75 of SkinMinerva.php:

if ( $wgMFEnableSiteNotice ) {

$banners[] = '<div id="siteNotice"></div>';

}

My understanding is that Central Notice will update the <div id="siteNotice"> with JavaScript when CentralNotice is turned on, and that Central Notice doesn't actually implement GetMobileNotice (the git history suggests GetMobileNotice was coded for generalized banners, but with a very specific callee, ZeroRatedMobileAccess, last year) so it should be safe to remove from SkinMobile.php:50.

Okay to proceed with removal of the line?

Thanks.

-Adam