*Erik*:
LQT: Importing project support desk from Wikimedia. Put up a list of 26
topic ideas & errors. Most of them we're ignoring.
Put in 5 patches for things he found there. Still working on a few of them.
Today: Need to do code review, and respond to Matthias' comments.
*Matt*:
Merged Thanks fix, resetting the container.
Reviewed & merged other small patches for core style guide, Vagrant.
Merged a volunteer patch.
Mostly working on Vagrant -- rebuilt it, hit a couple of bugs. Now working
for the most part, but performance isn't as good as it used to be.
Today: Get VE stuff done.
After that, working on preparing onboarding for Stephane.
*Matthias*:
Some housekeeping in Phabricator, merged some patches.
LQT: Imported CirrusSearch and VE pages -- Cirrus was fine, VE page had a
problem that's fixed in a patch.
Tomorrow: Clean up code review, run maintenance scripts.
Here's the screenshot that Matthias sent of what the default VE toolbar
looks like on Flow.
I assume that we could hide the components that aren't useful for us, but
even then, I think it feels really heavy above the entry field. It's a lot
of controls for a small entry field.
So -- seeing this confirms for me that we need to use Pau's design (also
attached), which puts the controls inside the entry field. If that turns
out to be unexpectedly crazy harder than we expect, then this would be a
distant second choice for v1, but it would have to be a pretty extreme
version of harder.
*Erik*:
Most of Friday, worked on Q1 - new model for replies. It's about 85% done,
will be on flow-tests
Trying to code review Matthias' Echo patch, add the parser function
dependency to Jenkins. Will figure it out with ops today.
Today: Parser functions for Echo tests, responding to comments on code
review.
*Matthias*:
Today: Looked at if it's possible to control scroll for the ToC scrolling
bug.
Fixed the Echo notification bug on Jenkins. With patches in Gerrit, it
seems to work fine.
Fixed some small international things that Nemo pointed out.
Looked at Q3 - placeholder makes most of the page blank. It seems to be
mysteriously fixed! We can't
Looked at ToC langsub problem -- couldn't reproduce the problem.
Added margin below ToC (Q9).
Tomorrow: 100% code review.
*Matt*:
Looked at fix for lost moderation logs, going to do a maintenance script to
fix it.
Changed JS code to always log.
Fixed and/or thing.
Merged a patch to Core.
Reviewed patch to Q4 add links to history for hidden comments. Also doing
it for deleted and suppressed, question on the ticket.
Review on Echo fix for Compact Personal Bar.
*Erik*:
Working on Mediawiki LQT test imports. Found a couple small problems,
continuing work on them today.
Today - a couple new Unbreak Now bugs from weekend, MM put up fix for one
-- Update to Pimple 2.x broken by Flow. Erik checked, Matt will review and
get that out.
Also Unbreak Now problem with purging action -- fixing that first thing
today and will get it out.
*Matt*:
Working on updating VE patch, responding to Matthias' comments.
Having some Vagrant problems today, trying to fix it.
Set up Flow on RESTbase page -- we talked about making a special page for
this.
Today: Review Thanks bug, fix Vagrant box.
Then get the VE stuff done.
*Erik*:
Yesterday: Code review.
Worked on LQT import from Mediawiki. The way that we store external links
-- the index doesn't work, because things get cut off at a certain length.
We'll have to change our primary key. Looking at whether it's happened in
other places.
That was the only problem, so today moving on to the other conversion tests.
*Matt*:
Deployed logging fixes, ran maintenance scripts.
Put up a patch to fix the getting started browser tests, and guided tour
regression.
Worked on VE editor -- that will be primary thing today.
*Erik*:
Undo is in code review (R3) -- turned out to be more code than anticipated.
Today: code review.
*Matt*:
Merged Erik's fix to "off by one" issue
Changed Thanks tooltip to say that it's public
RfC discussion
Merged all logging patches
Today:
Following up on VE
scheduled evening swot to cherrypick & deploy logging patches, and run
maintenance scripts
*Matthias*:
Working on missing regex requests, the storing part is done
Tomorrow - the other half for VE, backend
I was at the RFC meeting today, and we discussed
https://phabricator.wikimedia.org/T89733 .
I don't think it necessarily affects Flow, but it might, especially if
we do the "a Topic is one document" thing we keep talking about on-and-off.
Basically, there is currently a Content::getTextForSearchIndex(), but
this doesn't support structured data.
The proposal is to define various methods for Content and
ContentHandler, which would allow structured field definitions. For
example, we might have a originalPoster, commenter (fields can be
multi-value), etc.
The search backend stuff is pretty much done AFAIK, so this is more of a
note for the future.
Matt Flaschen
*Matt*:
Merged Jenkins patch to change guided tour documentation
Reviewed Matthias' & Erik's patches.
Put up an i18n patch for logging
*Matthias*:
Continued working on R1 spike -- add VE features to Flow. Link widget seems
functional. Getting close to closing the spike.
Danny asks if we can put it up on a test instance.
*Erik*:
Working on undo (R3) -- loading preview JS on undo pages. Working now for
edit post, header & summary. Summary may just have the text, without the
entire topic box. Undo should be done today.
*Erik*:
Working on undo. -- JS doesn't load, so preview doesn't work. Working more
on that today.
*Matthias*:
Working on VE spike -- has figured out what we don't want to do.
Keeps getting stuck with exceptions & problems -- things in the code that
he doesn't know how to touch.
Might help to talk to Trevor & VE team.
*Matt*:
Put up Echo styling patch
Reviewed and +2 Matthias' enhanced RC patches -- there's some work still to
go on the expanded results.
Updated VE patch.
Today: Finish VE toolbar bug. More code review.
*Erik*:
Friday -- working almost entirely on Undo functionality (R3). Mostly
working but finding weird edge cases.
Today: a few new things in code review, then work on Undo.
*Matthias*:
Been looking at VE spike (R1) -- Friday was getting our version up and
running. Found some exceptions. Will spend tomorrow also working on it.
*Matt*:
He figured out VE exceptions yesterday; he'll update patch today.
Reviewed Erik's next/previous diff patch.
Looked at conversations about Flow board deletions -- put up a quick fix so
that action=delete doesn't work for Topic pages.
Updated plaintext snippet patch.
Nick filed a bug about history page exception -- Erik has cherrypicked the
fix, and it'll go out today.
Code review today, then he'll look at toolbar issue that Matthias reported.